Skip to content

Remove bokeh upper bound#7413

Merged
jrbourbeau merged 7 commits into
dask:mainfrom
jrbourbeau:remove-bokeh-upper-bound
Mar 30, 2023
Merged

Remove bokeh upper bound#7413
jrbourbeau merged 7 commits into
dask:mainfrom
jrbourbeau:remove-bokeh-upper-bound

Conversation

@jrbourbeau

@jrbourbeau jrbourbeau commented Dec 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #7173
Closes #7414
Closes #7362

@github-actions

github-actions Bot commented Dec 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +       1         26 suites  +1   14h 14m 16s ⏱️ + 2h 18m 44s
  3 543 tests ±       0    3 435 ✔️ +       1     105 💤 +    1  3 ❌  - 2 
44 806 runs  +1 282  42 592 ✔️ +1 109  2 210 💤 +174  4 ❌  - 1 

For more details on these failures, see this check.

Results for commit 75c90d0. ± Comparison against base commit f102357.

This pull request skips 1 test. 
distributed.protocol.tests.test_protocol ‑ test_large_messages

♻️ This comment has been updated with latest results.

@consideRatio consideRatio mentioned this pull request Feb 6, 2023
Closed
@jrbourbeau jrbourbeau changed the title [DNM] Remove bokeh upper bound Remove bokeh upper bound Mar 29, 2023
jrbourbeau
jrbourbeau commented Mar 29, 2023
View reviewed changes

@jrbourbeau jrbourbeau left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I tried out bokeh=3.1 and things seem good. I looked at the dashboard, performance reports, and the labextension. This PR removed the bokeh version upper bound constraint, but we disallow bokeh=3.0.x

@mrocklin

mrocklin commented Mar 29, 2023 via email

Copy link
Copy Markdown
Member

ncclementi
ncclementi approved these changes Mar 30, 2023
View reviewed changes

@ncclementi ncclementi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you @jrbourbeau

@jrbourbeau jrbourbeau merged commit 215f379 into dask:main Mar 30, 2023
@jrbourbeau jrbourbeau deleted the remove-bokeh-upper-bound branch March 30, 2023 16:35
@jacobtomlinson jacobtomlinson mentioned this pull request Mar 31, 2023
Closed
@fjetter fjetter mentioned this pull request Mar 31, 2023
Closed
@fjetter

fjetter commented Mar 31, 2023

Copy link
Copy Markdown
Member

This appears to have caused some breakage #7732

@jrbourbeau jrbourbeau mentioned this pull request Apr 3, 2023
Merged
This was referenced Apr 11, 2023
Merged
Merged
@LukeWeidenwalker LukeWeidenwalker mentioned this pull request Jul 14, 2023
Merged
@consideRatio consideRatio mentioned this pull request Oct 25, 2023
Closed
@jacobtomlinson jacobtomlinson mentioned this pull request Mar 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncclementi ncclementi ncclementi approved these changes
@jacobtomlinson jacobtomlinson Awaiting requested review from jacobtomlinson jacobtomlinson is a code owner
@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@jrbourbeau @mrocklin @fjetter @ncclementi